search

babybuddy / babybuddy-for-android

Android client for the Baby Buddy webapp
MIT License
16 stars 6 forks source link

Show breast side on timeline, resolve #39 #45

Closed Xandersoft closed 1 year ago

Xandersoft commented 1 year ago
MrApplejuice commented 1 year ago

Hey Xandersoft,

Thank you very much for contributing! I will have time this weekend most likely to give this an in-depth look.

This will address #39.

MrApplejuice commented 1 year ago

Finally got around to look at the PR! Looks good. I hope you do not mind if I combine your image:

image

With the existing pictographic breast image so that the iconography is a bit equal. I think I would prefer that. Other than that, functional and looks good!

MrApplejuice commented 1 year ago

Took me quite some time to get back at this. Big thanks for the contribution.

I tried to make a combination of the L/R logos you created with the breast. Took some time to get it right so that this renders properly in small sizes. This is what I came up with.

To be fair: I only think that this is a tiny tiny improvement but at least the icons are in there which will ease translations in the future!