Captains can not submit orders

[jophillipsrtp]

I have 2 captains telling me they're not able to submit Orders on ROOMs. They're on their main site page, then they hit "Place an order" and once they get to the next page where you need to click on one of the sub categories for Orders and they are saying when they click nothing is working.

However, when I sign on our fake captain view account, it does let me make an order....

Theses sites where they're having issues are: 18027RWC and 18022MEN

Sorry this is difficult because its hard to tell if captains are just not doing something correctly, or if there is actually a problem.

[caripang]

FYI - I just tested this by adding my personal captain e-mail account as a construction captain to both sites and was able to successfully access the orders.

Cari Pang Chen | Associate Director & Acting Executive Director

Rebuilding Together Peninsula 841 Kaynyne Street | Redwood City | 94063 (W): 650.366.6597 x224 | (C): 650.451-1787 www.RTPeninsula.org http://www.rebuildingtogetherpeninsula.org/

A safe and healthy home for every person

Note: When visiting our office, please note that we have a back parking lot accessible via 852 Charter Street, between Bay & Spring.

On Fri, Mar 23, 2018 at 12:54 PM, jophillipsrtp notifications@github.com wrote:

I have 2 captains telling me they're not able to submit Orders on ROOMs. They're on their main site page, then they hit "Place an order" and once they get to the next page where you need to click on one of the sub categories for Orders and they are saying when they click nothing is working.

However, when I sign on our fake captain view account, it does let me make an order....

Theses sites where they're having issues are: 18027RWC and 18022MEN

Sorry this is difficult because its hard to tell if captains are just not doing something correctly, or if there is actually a problem.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/babybunny/rebuildingtogethercaptain/issues/478, or mute the thread https://github.com/notifications/unsubscribe-auth/APkjDheyQkxJGFb0DjmVC6hVT5E16w5mks5thVMQgaJpZM4S5StL .

[caripang]

FYI - confirmed that the Captain still seems to be experiencing issues for 18027RWC. He is on a PC, using IE or a Chrome browser. I asked him to try again with Chrome and let us know if that works better. He is able to get to the site page, and then successfully click on "Place an Order" but is unable to click on the actual order buttons in the "Make an Order" page.

[caripang]

This issue was reported again today, this time for a Captain at 18029RWC, Spence Leslie. At first, we thought it was because he has four different captain entries all with spencerkleslie@gmail.com as his login, but he is able to get in now but still can't access the individual order forms.

[babybunny]

Thanks for troubleshooting this. Very helpful.

Since Cari was able to get it working on the same site, we know it's not a problem with the data on that site.

Since it doesn't affect all sites it's not a bug in the server code.

Since it's happening to multiple captains it's unlikely to be a broken browser.

I suspect a JavaScript error and something in common for the captains who are affected. Like a common browser version perhaps.

[babybunny]

Looking at logs for the 18027RWC site. Accessed by Captain at 5056998924091392 2018-03-26 09:08:18.722 PDT

Browser is IE 11. Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko

After starting the order flow and selecting a the browser needs to load existing orders and details on the selected order form. So it loads data from the server:

POST /custom_api.order_form_detail POST /custom_api.order_existing

In these logs I'm seeing frequent and repeated calls to these two. Like the browser is stuck in a funny state and keeps trying to load the data. Data responses appear to be valid and fast.

For example, at 2018-03-26 11:01:00.730 PDT We have 5 calls to each of these APIs within 3 seconds.

Next step is to look at logs for other sites and see if we have similar behavior.

[babybunny]

For the site 18029RWC 5283057548394496 I see Captain trying to create an order at 2018-04-03 16:22:15.344 PDT

Same browser Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko

Similar pattern of accessing those two APIs repeatedly. Now I think that these APIs get called ever time the user clicks one of the order from buttons. It's not necessarily the browser going crazy and making repeated calls by itself. More likely the user is clicking around trying to get something to happen.

I'll take a look at the third site reported.

[babybunny]

I see another user with the same browser 18018EPA Linda. Let's see if Linda can make an order. If not, we can be pretty sure it's the browser.

[babybunny]

Confirmed it's the same browser on 18022MEN.

Recommend using chrome browser for now and I'll see if I can spot an obvious error in the JavaScript code. It's going to be hard to fix this one because I don't have this browser so I can't reproduce the issue.

[babybunny]

Added error tracking. Now we can have an affected user test again and I'll see if there are errors.

[babybunny]

The system captured a new error yesterday.

Message: Expected ';' File: https://rebuildingtogethercaptain.appspot.com/js/lib/underscore.js 1457 : 7

It's in _.template()

for .. of loops are not supported by IE. need to remove all of them and replace with Array.forEach or similar.

$ egrep -r "for.?(.+ of " gae/js/app gae/room/templates/ gae/js/app/templates/order_logistics.html: <% for (logistics_date of logistics_dates.models) { %> gae/js/app/templates/order_logistics.html: <% for (sitecaptain of sitecaptains.models) { %> gae/js/app/templates/order_select_items.html: <% for (oe of order_existing.models) { %> gae/js/app/templates/order_select_items.html: for (item of items) { gae/js/app/templates/sitecaptains.html:<% for (sc of sitecaptains) { %>

[babybunny]

This should be fixed now.

[caripang]

I am reopening this issue as Spence can access the order forms now but cannot enter a quantity and submit an order. I have not been able to personally duplicate unfortunately as it worked for me when I tested as a captain in Chrome. not sure if this is related to other issues re: his browser?

[babybunny]

This seems to fit into the category of issues that were critical at one point, but that point has passed and the issue is not clearly understood.

Trying to figure out some good next steps.

The root cause seems to be that the web app doesn't work with certain browsers. Of course, it's difficult to support all browsers, so it becomes a question of which browsers to support, and what to do about browsers that don't work.

One approach I've seen on other sites is to notify users who are on unsupported browsers and tell them to use a different browser. This is annoying for he user but it prevents the greater frustration of having a broken experience within the web app.