Closed ValorNaram closed 5 years ago
See https://github.com/babykarte/babykarte.github.io/issues/84#issuecomment-507821799 to get an idea what I am talking about. you may discuss which tags Babykarte must evaluate and show.
baby wheelchair surface description access min_age max_age material Capacity
baby
No specification found in wiki.
surface
Which values are logical to apply on a playground equipment?
access
Which values are logical to apply on a playground equipment?
@Discostu36 See my as unstable labeled commit. It is really that what you want? Most of the information the keys from your list unveil are not important for Mainstream society.
Someone should preview the translation in english and german.
@NicolasGrosjean Please don't translate in french yet, first it must be previewed, corrected and improved. But I added the entries you need to translate right into js/fr.js
so you can start translating easily when the time and air is right.
@Discostu36 I played with the german language a little bit and added some humour. Some example: gehackter geschnitzelter Holzboden
@team Please preview, correct and reupload.
I'll work on it when I'm back from vacation.
baby
No specification found in wiki.
https://wiki.openstreetmap.org/wiki/Key:playground#Descriptive_tags
Please replace the list of materials with this one:
This covers 95% of material tags on playground equipment (at least in Europe).
I actually don't know what is interesting for consumers and what is not. But if the data is there we should show it.
I'll have a look at the surface list later this week. Sorry for the delay.
Please use these surfaces (91 %): (Source)
@Discostu36 Please check my commit and make changes to the german translation and english translation (if any).
@NicolasGrosjean Please don't translate to french yet. If you want you can help improving the translation for english in file js/en.js
I have some alignment issues when there is a lot of text in the popup
I have not succeeded to display a specific playground in Babykarte. It is maybe not linked to that but to overpass which do not response.
I have some alignment issues when there is a lot of text in the popup
Are you sure this alignment issue only occurrs when there's a lot of text in the popup?
@NicolasGrosjean The playground is not displayed because we don't show playgrounds with a min_age>3.
@ValorNaram You are right, it is not linked to the size of the popup, there was alignment issues in all other popup. The issue is not the same as yesterday.
@Discostu36 Thanks for the answer.
A month ago, you have listed a list of attributes to display. The list has been shorten ?
baby wheelchair surface description access min_age max_age material Capacity
For example, I don't see min_age and max_age in these 2 playgrounds equipment.
For the climbing one, it is also strange to have Playground equipment as name.
A month ago, you have listed a list of attributes to display. The list has been shorten ?
Might be that I forget them to add because initialy I had to leave them out. I will investigate that.
For the climbing one, it is also strange to have Playground equipment as name.
The combination playground=climbing
isn't supported because it is
that's why there is no string defined in the language reference files. The name Playground equipment
is a fallback Babykarte shows in cases like these.
@ValorNaram You are right, it is not linked to the size of the popup, there was alignment issues in all other popup. The issue is not the same as yesterday.
Please tell me which browser and which operating system do you use. I cannot reproduce your problem but depending on your answer it may be necessary to tweak the CSS rules how a browser should/must render. I hope it is no issue with the emojis/icons itself.
The list has been shorten?
No we did not short the list. But sometimes we discuss things related to Babykarte privately via Telegram. We know that's not very transparent but sometimes things are better to solve throw chatting or voice telephony. But we keep this to a minimum. Much of the Babykarte stuff will be posted here. @NicolasGrosjean You're member of the Babykarte team, so if you have interest and have Telegram, just drop @Discostu36 or me an email with your Telegram username and we open up a group of three.
Despite this we have currently no plans to open our conversation to the public which would be very easy with Telegram.
Firefox Quantum 68.0.1 (64 bits) on Windows 10
Please remove min_age and max_age from the pop-up when not defined.
Two things I'd like to know if they're still on your to-do list:
- Dots instead of markers for playground equipment
Done
- Resizing of popups according to content
The popup seems sometimes so big on little content because its size is being automatically adjusted to fit the content that's the largest of all. In our case that means it's height depends on the height of the tab icons and on the height of the tab content which is always on a fixed height. The width depends on the width of the two links ( Edit in OSM Report wrong information
)in the footer of every popup. That's a pretty and common normal procedure as it is done by at least all major browsers.
@Discostu36 Are you finish improving the translation of english and german?
Yes, I think I am.
Still one bug: The additional information are not displayed (tested with this swing [baby=] and this structure [surface=])
Still one bug:
Bug has been fixed by me!
@NicolasGrosjean you are now allowed to translate some strings into french :) Everything has been prepared just for your show (I am just a little bit joking :)).
I incoporated @Discostu36 s' changes he's made in the english translation into the french translation file. Be sure to fetch the newest version of the code from the beta
branch. Just edit the js/fr.js
file in devel
. With the find
function you can search the document for the string pieces ending with (EN)
. This should make it pretty easy for you to translate.
@ValorNaram You are right, it is not linked to the size of the popup, there was alignment issues in all other popup. The issue is not the same as yesterday.
Does this problem persists? I tweaked the design a little bit in order to be more friendly to mobile users.
Playground equipment is still in the pop-up when there is none tagged:
Is it really a bug? It says "Playground equipment" on playgrounds and in real life there are playground equipments on every playground (proove me wrong).
Sure there are, but it's useless information. We could also add "food available" to every restaurant...
Ok! Babykarte now behaves differently
This references to #93, #100, #84, #99 and https://github.com/babykarte/babykarte.github.io/issues/84#issuecomment-507821799
What is this about
In this issue we will talk about the content of the popup for playground equipment. So we can show users the most important information they likely want and love.
What to do to get this solved
js/overpass.js/babyTab
needs to be more abstract (supporting multiple databases for popup content displaying and clustering rules). Currently we have just one database as a JSON variablejs/overpass.js/babyData
. In future they will be two or more that must be handled by the function. Functionjs/overpass.js/babyTab
must be renamed injs/overpass.js/processContentDatabase
or similar.js/overpass.js/colorcode
must be manually feed to thejs/overpass.js/processContentDatabase
function so it can be excluded for the run for playground equipment popup rendering ergo **no coloring for the "bullet points" (see https://github.com/babykarte/babykarte.github.io/issues/84#issuecomment-507821799 for the meaning of this wording)~js/overpass.js/babyData
??? Cannot think about a better option yet~ Get subtitles with functionjs/filters.js/getSubtitle