ValorNaram commented 5 years ago

84#issuecomment-507821799

What is this about

In this issue we will talk about the content of the popup for playground equipment. So we can show users the most important information they likely want and love.

What to do to get this solved

[x] Agreeing on the content level
[x] The function js/overpass.js/babyTab needs to be more abstract (supporting multiple databases for popup content displaying and clustering rules). Currently we have just one database as a JSON variable js/overpass.js/babyData. In future they will be two or more that must be handled by the function. Function js/overpass.js/babyTab must be renamed in js/overpass.js/processContentDatabase or similar.
[x] ~The popup content displaying and clustering rules coloring rule defined in a JSON variable js/overpass.js/colorcode must be manually feed to the js/overpass.js/processContentDatabase function so it can be excluded for the run for playground equipment popup rendering ergo **no coloring for the "bullet points" (see https://github.com/babykarte/babykarte.github.io/issues/84#issuecomment-507821799 for the meaning of this wording)~
[x] ~???~ Provide fallback for cases in which playground equipment POIs aren't equiped with the name key ~. ??? Don't know how to develop this~ with conditional sentences (code)
[x] ~??? Provide a subtitle which unveils the type of the playground equipment to the user. Perhaps checking of match in "leisure" --> "children" in JSON variable js/overpass.js/babyData ??? Cannot think about a better option yet~ Get subtitles with function js/filters.js/getSubtitle

ValorNaram commented 5 years ago

Agreeing on the content level

See https://github.com/babykarte/babykarte.github.io/issues/84#issuecomment-507821799 to get an idea what I am talking about. you may discuss which tags Babykarte must evaluate and show.

Discostu36 commented 5 years ago

baby wheelchair surface description access min_age max_age material Capacity

ValorNaram commented 5 years ago

baby

No specification found in wiki.

surface

Which values are logical to apply on a playground equipment?

access

Which values are logical to apply on a playground equipment?

ValorNaram commented 5 years ago

@Discostu36 See my as unstable labeled commit. It is really that what you want? Most of the information the keys from your list unveil are not important for Mainstream society.

ValorNaram commented 5 years ago

Someone should preview the translation in english and german.

@NicolasGrosjean Please don't translate in french yet, first it must be previewed, corrected and improved. But I added the entries you need to translate right into js/fr.js so you can start translating easily when the time and air is right.

@Discostu36 I played with the german language a little bit and added some humour. Some example: gehackter geschnitzelter Holzboden

@team Please preview, correct and reupload.

Discostu36 commented 5 years ago

I'll work on it when I'm back from vacation.

Discostu36 commented 5 years ago

baby

No specification found in wiki.

https://wiki.openstreetmap.org/wiki/Key:playground#Descriptive_tags

Discostu36 commented 5 years ago

Please replace the list of materials with this one:

wood
plastic
rope
steel
metal

This covers 95% of material tags on playground equipment (at least in Europe).

Discostu36 commented 5 years ago

I actually don't know what is interesting for consumers and what is not. But if the data is there we should show it.

Discostu36 commented 5 years ago

I'll have a look at the surface list later this week. Sorry for the delay.

Discostu36 commented 5 years ago

Please use these surfaces (91 %): (Source)

sand
grass
woodchips
rubbercrumb
tartan
gravel
paving_stones
wood
asphalt

ValorNaram commented 5 years ago

@Discostu36 Please check my commit and make changes to the german translation and english translation (if any).

@NicolasGrosjean Please don't translate to french yet. If you want you can help improving the translation for english in file js/en.js

NicolasGrosjean commented 5 years ago

I have some alignment issues when there is a lot of text in the popup

Url to reproduce it

NicolasGrosjean commented 5 years ago

I have not succeeded to display a specific playground in Babykarte. It is maybe not linked to that but to overpass which do not response.

ValorNaram commented 5 years ago

I have some alignment issues when there is a lot of text in the popup

Are you sure this alignment issue only occurrs when there's a lot of text in the popup?

Discostu36 commented 5 years ago

@NicolasGrosjean The playground is not displayed because we don't show playgrounds with a min_age>3.

NicolasGrosjean commented 5 years ago

@ValorNaram You are right, it is not linked to the size of the popup, there was alignment issues in all other popup. The issue is not the same as yesterday.

NicolasGrosjean commented 5 years ago

@Discostu36 Thanks for the answer.

A month ago, you have listed a list of attributes to display. The list has been shorten ?

baby wheelchair surface description access min_age max_age material Capacity

For example, I don't see min_age and max_age in these 2 playgrounds equipment.

For the climbing one, it is also strange to have Playground equipment as name.

ValorNaram commented 5 years ago

A month ago, you have listed a list of attributes to display. The list has been shorten ?

Might be that I forget them to add because initialy I had to leave them out. I will investigate that.

ValorNaram commented 5 years ago

For the climbing one, it is also strange to have Playground equipment as name.

The combination playground=climbing isn't supported because it is

not being standardized nor documented or
not very often used

that's why there is no string defined in the language reference files. The name Playground equipment is a fallback Babykarte shows in cases like these.

ValorNaram commented 5 years ago

@ValorNaram You are right, it is not linked to the size of the popup, there was alignment issues in all other popup. The issue is not the same as yesterday.

Please tell me which browser and which operating system do you use. I cannot reproduce your problem but depending on your answer it may be necessary to tweak the CSS rules how a browser should/must render. I hope it is no issue with the emojis/icons itself.

ValorNaram commented 5 years ago

The list has been shorten?

No we did not short the list. But sometimes we discuss things related to Babykarte privately via Telegram. We know that's not very transparent but sometimes things are better to solve throw chatting or voice telephony. But we keep this to a minimum. Much of the Babykarte stuff will be posted here. @NicolasGrosjean You're member of the Babykarte team, so if you have interest and have Telegram, just drop @Discostu36 or me an email with your Telegram username and we open up a group of three.

Despite this we have currently no plans to open our conversation to the public which would be very easy with Telegram.

NicolasGrosjean commented 5 years ago

Firefox Quantum 68.0.1 (64 bits) on Windows 10

Discostu36 commented 5 years ago

Please remove min_age and max_age from the pop-up when not defined.

Discostu36 commented 5 years ago

Two things I'd like to know if they're still on your to-do list:

Dots instead of markers for playground equipment
Resizing of popups according to content

ValorNaram commented 5 years ago

Dots instead of markers for playground equipment

Done

Resizing of popups according to content

The popup seems sometimes so big on little content because its size is being automatically adjusted to fit the content that's the largest of all. In our case that means it's height depends on the height of the tab icons and on the height of the tab content which is always on a fixed height. The width depends on the width of the two links ( Edit in OSM Report wrong information )in the footer of every popup. That's a pretty and common normal procedure as it is done by at least all major browsers.

ValorNaram commented 5 years ago

@Discostu36 Are you finish improving the translation of english and german?

Discostu36 commented 5 years ago

Yes, I think I am.

Still one bug: The additional information are not displayed (tested with this swing [baby=] and this structure [surface=])

ValorNaram commented 5 years ago

Still one bug:

Bug has been fixed by me!

ValorNaram commented 5 years ago

Translating into french

@NicolasGrosjean you are now allowed to translate some strings into french :) Everything has been prepared just for your show (I am just a little bit joking :)).

I incoporated @Discostu36 s' changes he's made in the english translation into the french translation file. Be sure to fetch the newest version of the code from the beta branch. Just edit the js/fr.js file in devel. With the find function you can search the document for the string pieces ending with (EN). This should make it pretty easy for you to translate.

ValorNaram commented 5 years ago

@ValorNaram You are right, it is not linked to the size of the popup, there was alignment issues in all other popup. The issue is not the same as yesterday.

Does this problem persists? I tweaked the design a little bit in order to be more friendly to mobile users.

Discostu36 commented 5 years ago

Playground equipment is still in the pop-up when there is none tagged:

grafik

ValorNaram commented 5 years ago

Is it really a bug? It says "Playground equipment" on playgrounds and in real life there are playground equipments on every playground (proove me wrong).

Discostu36 commented 5 years ago

Sure there are, but it's useless information. We could also add "food available" to every restaurant...

ValorNaram commented 5 years ago

Ok! Babykarte now behaves differently

babykarte / babykarte.github.io

Popup for playground equipment #103

This references to #93, #100, #84, #99 and https://github.com/babykarte/babykarte.github.io/issues/84#issuecomment-507821799

What is this about

What to do to get this solved

Agreeing on the content level

Translating into french