search

babylonchain / babylon-finality-gadget

2 stars 2 forks source link

test: add itest #30

Closed lesterli closed 2 months ago

lesterli commented 2 months ago

Summary

This PR creates a test case to test the query whether the block is Babylon finalized.

Test Plan

make test-e2e
bap2pecs commented 2 months ago

we realized that wrapping a testmanger in another is not great. so we will wait until https://github.com/babylonchain/finality-provider/pull/433 is merged to update this PR accordingly

bap2pecs commented 2 months ago

@SebastianElvis actually do you feel it makes more sense to put these test in the FP repo? so there are two options:

  1. put the test in FP repo. import from DA-SDK repo to test
  2. put the test in this DA-SDK repo. import from FP repo to test

which one do you think is better?

My preference option 1. b/c the test setup and logic is very similar to other FP e2e tests.
lesterli commented 2 months ago

Close it and this test case is moved to the FP repo with this PR.