babylonchain / babylon-finality-gadget

3 stars 3 forks source link

bitcoin rpc query and setup btc test infra #41

Closed lesterli closed 2 months ago

lesterli commented 3 months ago

Summary

https://github.com/babylonchain/babylon-da-sdk/pull/39#pullrequestreview-2155202342

Gai: Just wanted to understand the context. Why not use btc client like https://github.com/babylonchain/staking-indexer/blob/51d98f1dbafda2fbbe550599c83331b549d26a6c/btcclient/client.go#L23?

https://github.com/babylonchain/finality-provider/pull/483#discussion_r1667869280

Runchao: besides mocking BTC node, one can also leverage the https://github.com/btcsuite/btcd/tree/master/integration/rpctest package for testing things against an almost real BTC node. But this can be done in the future.

Tasks

parketh commented 3 months ago

now updated Bitcoin rpc to use btcclient with this commit

bap2pecs commented 2 months ago

Kamino closed and cloned this issue to babylonlabs-io/babylon-finality-gadget