babylonchain / babylon-finality-gadget

3 stars 3 forks source link

ensure the changes here will not break FP e2e tests #52

Closed bap2pecs closed 3 months ago

bap2pecs commented 4 months ago

Summary

We want to ensure that changes here will still work with the FP repo, but the problem is that the e2e tests are in the FP repository.

We are currently getting the commit hash in this repo and locally updated it in the cloned FP repository. Then we run e2e tests manually in the FP repo

But imagine having to do this every time we make a PR in this repo—it's tedious. So, a proposed solution is to rely on the CI in this repo.

how it works should be first we clone the FP repository and get the commit hash of the PR here. then replace the dependency in the FP repository and run go mod tidy, and then run e2e tests

Tasks

bap2pecs commented 3 months ago

Kamino closed and cloned this issue to babylonlabs-io/babylon-finality-gadget