refactor: decouple config, sdk, and client - Githubissues

babylonchain / babylon-finality-gadget

2 stars 2 forks source link

refactor: decouple config, sdk, and client #55

Closed bap2pecs closed 1 month ago

bap2pecs commented 2 months ago

Summary

per @gitferry's comment https://github.com/babylonchain/babylon-finality-gadget/pull/38#pullrequestreview-2155195317, we should decouple config, sdk, client and etc

more context: https://github.com/babylonchain/babylon-finality-gadget/issues/43

Test Plan

make lint
make test

bap2pecs commented 1 month ago

Resolved comments:

make BtcClient, and ContractAddr private
ChainType -> ChainID
pass RPCAddr to the SDK config
added docstring for QueryIsBlockBabylonFinalized