babylonchain / babylon

Main repo for Babylon full node
https://babylonchain.io
Other
240 stars 170 forks source link

chore(inactivity): Rename `inactive` flag to `sluggish`, add queries, events, and metrics #714

Closed gitferry closed 4 months ago

gitferry commented 4 months ago

The inactive flag of a finality provider is confused with the finality providers that are not in the active set. So, this PR is to rename the flag to sluggish, which is a common concept in the BFT world to describe validators who should vote but the votes are delayed for some reason thus committing sluggish faults.

This PR also made the following additions:

gitferry commented 4 months ago

great work! Sluggish sounds a bit weird, but I agree inactive may be super confusing so 👍

Yeah, tbh it's werid to me, too, but it's just temporal and will be changed to jailed eventually