search

babylonchain / simple-staking

Simple staking application
Other
4 stars 13 forks source link

hotfix to fit height the right section #261

Closed jeremy-babylonlabs closed 5 months ago

jeremy-babylonlabs commented 5 months ago

CleanShot 2024-06-17 at 18 46 34@2x CleanShot 2024-06-17 at 18 45 46@2x CleanShot 2024-06-17 at 18 45 17@2x

The previous implementation was setting a max height in the scroll container. which was fine but it won't adjust based on the right section height.

In this pr we just fix it by adjusting the max height. To properly fix this, I think we can have dynamic setting of the div height based on the right content using js, or to change the way this part of the code is currently structured, but that would be quite some changes. Would suggest to fix this in another issue ticket since it's close to launch.

jrwbabylonlab commented 5 months ago

@gbarkhatov let it to you since this is a css change

jrwbabylonlab commented 5 months ago
image

hmm... this leaves a quite big space when there is no custom fee

gbarkhatov commented 5 months ago

At the moment the solution is not to include this PR until we come up with better design