Fixed not calling completion block when transitioning drawer to dismissed state

babylonhealth / DrawerKit

DrawerKit lets an UIViewController modally present another UIViewController in a manner similar to the way Apple's Maps app works.

https://github.com/Babylonpartners

MIT License

781 stars 44 forks source link

Closed ilyapuchka closed 5 years ago

ilyapuchka commented 5 years ago

Dismissing happens already during animation transition so when it is called in the closure it has no effect and completion block is not called

zzcgumn commented 5 years ago

Code changes are okay. Can we merge things without tickets these days? I thought not.

ilyapuchka commented 5 years ago

@zzcgumn there is a ticket related to this change and another PR in our main repo that references this one, I think it should be ok for reference.

ilyapuchka commented 5 years ago

Thanks @viorel15 and @zzcgumn