EPIC: Add full validations - Githubissues

babylonlabs-io / babylon-contract

CosmWasm smart contracts for Babylon integration

Other

10 stars 6 forks source link

EPIC: Add full validations #7

Open maurolacy opened 3 months ago

maurolacy commented 3 months ago

@maurolacy cloned issue babylonchain/babylon-contract#84 on 2024-05-03:

After basic validations (#82), let's complete the validation logic after the original Go code.

Related to #82. Also, likely requires #76.

SebastianElvis commented 2 months ago

After #46 and #56, most of the reality checks are done (feature flag for lite/full version, correctness of BTC staking library, etc..).

The following includes the missing verification rules. Those will be picked up later.

Finality provider registration request

[x] Verify PoP

BTC delegation request

[ ] Ensure staking tx is included the BTC light client
[ ] Ensure staking tx is k-deep
[ ] Ensure staking tx timelock has more than w BTC blocks left
[ ] Verify PoP
[x] Verify covenant signatures over slashing tx
[ ] Ensure unbonding time is max(min_unbonding_time, w)
[x] Ensure unbonding tx is spending the given staking tx
[x] Ensure consistency bweteen unbonding tx and unbonding slashing tx
[x] Verify staker's signature over slashing path of unbonding tx
[x] Verify covenant signatures over unbonding slashing tx
[ ] Ensure unbonding tx fee is not too low

BTC undelegation request

[x] Ensure BTC delegation is active
[x] Verify staker's signature over the unbonding tx

Slashed BTC delegation

[x] Ensure BTC delegation is active
[x] Ensure the SK corresponds to a FP PK that the delegation restakes to