search

babylonlabs-io / babylon-contract

CosmWasm smart contracts for Babylon integration
Other
10 stars 7 forks source link

F/optimizer ci #73

Closed maurolacy closed 2 months ago

maurolacy commented 2 months ago

Enables optimiser run during PRs / on branches.

maurolacy commented 2 months ago

The only issue is that now the CI run goes from ~2 minutes to ~10 minutes :-/.

Perhaps we remove the cosmwasm check and integration tests? And we can still run those when merging to main. WDYT?

SebastianElvis commented 2 months ago

The check is still necessary imo we need to ensure 1) wasm binaries can indeed be executed on CosmWasm env, and 2) the contract size is not bloated. I don't have better idea for optimising it though

maurolacy commented 2 months ago

This last version is a good in-between solution IMO. We check that contract binaries compile, and we run the full checks only when merging to main / on release tags.

And, it runs in ~5 minutes, which is half the full run.

maurolacy commented 2 months ago

I would say, let's go with this, and we can tune / adjust it later if needed / considered.

maurolacy commented 2 months ago

Also, we should consider building our own optimiser docker image and push it to docker hub. So that we don't build it every time. Will create an issue for it.

Update: #74.

SebastianElvis commented 2 months ago

So that we don't build it every time. Will create an issue for it.

Good idea :+1: that shall slash the CI execution time a lot