chore: Improve external events format

gitferry commented 1 month ago

This PR flattened the external events and changed all the event fields to string so that it's easier for subscribers to parse them

SebastianElvis commented 1 month ago

It seems that the label should be backport v0.12.x (space in between) as per https://github.com/marketplace/actions/backporting?

KonradStaniec commented 1 month ago

@jrwbabylonlab does primitive numbers as strings also improve situation on api side ?

From my point of view this is a bit bad 😅 as now I am looking at number in some events and see string and I do not not know:

does this number is in hex bytes ?
does this number is in string decimal representation ?
does this number is in string binary representatin ?

I.e proto file loses any documentation qualities about numbers.

EDIT: It seems cosmos-sdk use events this way, so probably every tooling here is expects string in events. Example: https://github.com/cosmos/cosmos-sdk/blob/main/x/staking/keeper/msg_server.go#L559. Lets leave it as it is 👍

jrwbabylonlab commented 1 month ago

Just adding a note here as already discussed in DM: We should review the fields with omitemty as not all fields are optional. such as btcPk across all types.

babylonlabs-io / babylon

chore: Improve external events format #169