search

babylonlabs-io / babylon

Other
23 stars 15 forks source link

chore: Bitcoin heights and depths made uint32 #181

Closed vitsalis closed 1 month ago

vitsalis commented 1 month ago

Resolves #179

This is an impactful change that brings the BTC height types that we use more in sync with the expected types for BTC block heights, similar to those that are used by other libraries. It is part of the code improvement efforts that we are doing in preparation of the next testnet.

Given that it touches many files, I believe that this change should happen sooner than later so that it can be appropriately tested.

vitsalis commented 1 month ago

LGTM! Do we want to make the same change to auxiliary programs?

yep, I expect this can be handled when auxiliary programs are updated to the latest Babylon.