search

babylonlabs-io / babylon

Other
23 stars 15 forks source link

chore: add check in finality for block height finality parameter to accept finality vote/pubrand #204

Closed RafilxTenfen closed 3 weeks ago

RafilxTenfen commented 4 weeks ago

Add finality param to minimum block height to allow receiving Finality and Pub Rand Commit of x/finality

This value is a module parameter and it can be updated by governance proposal

RafilxTenfen commented 3 weeks ago

Will be modified to block finality vote and pub rand commit before activation height

RafilxTenfen commented 3 weeks ago

I was thinking it might be better to make the activation height a parameter other than hardcoding. Major benefit is that we don't need to care about what btc network we are running but just parameterize it in prepare-genesis. Wdyt?

We could add it as a parameter, but after the activation height is reached it could be removed and if we have in proto it would be a deprecated value forever there until we have a new proto version which is pretty difficult So, in my mind we have a few possibilities to change the activation height based on the BTC network

from offline discussion, move to parameters instead of hardcoded