Support for submitting RBF of staking and withdrawal transactions - Githubissues

babylonlabs-io / simple-staking

Other

8 stars 9 forks source link

Support for submitting RBF of staking and withdrawal transactions #115

Open vitsalis opened 2 months ago

vitsalis commented 2 months ago

Staking or withdrawal transactions might be stuck and not included to the Bitcoin ledger due to the usage of low fees. As those transactions are RBF enabled, the staking UI should have functionality for users to RBF these transactions. Nice to have feature with low priority.

jrwbabylonlab commented 2 months ago

Staking and withdraw are already RBF supported in btc-staking-ts. what's the scope of this issue?

gbarkhatov commented 1 month ago

@vitsalis @jrwbabylonlab should we close it? Staking is definitely RBFable, I guess withdrawal also but I never tried to RBF the withdrawing TX

jrwbabylonlab commented 1 month ago

agree. closing

vitsalis commented 1 month ago

This issue refers to the staking app allowing users to replace by fee their stalled transactions through the UI. Updating the description to reflect that.

jrwbabylonlab commented 1 month ago

What's the expected timeline for this? @vitsalis seems to be a nice to have feature as mempool already does that

vitsalis commented 1 month ago

How does mempool already do that?

jrwbabylonlab commented 1 month ago

nvm, mempool does this, not RBF https://mempool.space/accelerator

jrwbabylonlab commented 1 month ago

@vitsalis what's the expected timeline for this task to be included? Are we still planning to add more features? If possible, i would argue it's part of phase 2, but also nice to have feature with low priority

vitsalis commented 1 month ago

No hard timeline. As noted in the issue description, it's a nice to have feature with low priority.

jrwbabylonlab commented 1 month ago

Just adding a note here in case we forgot:

We need to think carefully on how UI should look like for phase 2 delegation. Once an existing EOI has been submitted into BBN, staker can no longer modify the staking tx in this EOI. Hence RBF won't work in a traditional way.
Some thoughts on how it might work from Vitals: "If a transaction is pending inclusion in BTC, the user can have access to a "bump fee" button. Once they do this, they create a new staking transaction and go through the EOI flow again, i.e. they see pending verification, verified, submit to btc etc."