search

babyman / quick-tabs-chrome-extension

A quick tab list and switch plugin inspired by the intelliJ IDEA java IDE
BSD 3-Clause "New" or "Revised" License
985 stars 171 forks source link

Fix for babyman/quick-tabs-chrome-extension#363 #377

Closed Wizek closed 6 days ago

Wizek commented 1 year ago

A quick and simple fix, I've been using it for about 2+ weeks now with great results. The issue is gone, and I did not notice any other issues (though while I do use quite a lot of app shortcuts, I have not tested it extensively with pop-out dev tools windows (which are handled specially by chrome), only a bit at the start where they seemed to work)

Fixes #363

stale[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Wizek commented 6 months ago

Works well under heavy use ever since then, no issues noted so far.

rb-109 commented 6 days ago

@Wizek - Thank you so much for doing this. This bug has really reduced the usefulness of the extension for me, as I use the Google Chat web app, and the MRU just gets stuck on that and stops working. However, this does not seem to be in production yet. Is this correct?

@babyman Is this just awaiting your review? If so, please can you review and merge as this is the biggest flaw in what is otherwise a basically perfect extension

babyman commented 6 days ago

@rb-109 thanks for flagging this, I have merged the code but I already submitted the update for 2024.11.24 for review. Seems that withdrawing that and resubmitting may slow down the review process :|. I'll push this once the current update clears.

@Wizek, thanks for finding and fixing this bug, I tweaked the code a little after the merge but the behaviour should be the same. Let me know if you have any concerns :)

babyman commented 4 days ago

Uploaded the update today for review, hopefully it should be live in a couple of days.