Closed rossjones closed 3 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository.To trigger a single review, invoke the
@coderabbitai review
command.
When ranking jobs to send a job to, exclude those that are not connected or not approved. By defaults nodes MUST be both approved and connected, but we have added options to the NodeSelector (in the form of
orchestrator.NodeSelectionCriteria
) to allow for explicit specification of whether we want them to be approved/connected.To make this workable, we change the default node state to APPROVED, requiring aconfig-option to rely on manual approval - it is this way around to ensure there is no required change for users upgrading to use this feature until they are ready to enforce it.