Closed frrist closed 2 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
I don't think we need this change given you introduced a short timeout when querying server version here #3964
It might make sense to give it sometime and see if that changes hits the sweet spot of improved user experience where they can easily know if their clients are outdated, and not hang if client is disconnected. Feel free to reduce the 3 seconds timeout to 2 seconds if you believe it is not short enough
@aronchick what do you think?
I'll be honest, I can see both sides.
Is there a scenario where someone should be able to get the version of a binary without connecting to a server? yes - i just downloaded it.
Is the function of our client app ONLY to connect to the server? Yes, so it makes sense we do that too.
I guess the ideal user experience, on first download would for this to come back in 1 second.
CLIENT SERVER LATEST UPDATE MESSAGE
v1.3.0 Disconnected v1.3.0
And the moment API_Server (or whatever) is set -
CLIENT SERVER LATEST UPDATE MESSAGE
v1.3.0 v1.3.0 v1.3.0
We should also have a bacalhau connect <IP_ADDRESS>
command....
I like the suggestion of giving feedback to the user that we couldn't figure out the server's version because it was disconnected. So reducing the timeout from 3 seconds to possibly 1 second should do the trick instead of only retrieving the client version by default
version
command with '--server'. The default value of '--server' is false. This results in theversion
command always succeeding.New Behavior: