Closed frrist closed 1 month ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
I am sorry but I don't agree with the approach. You are removing almost all of our test scenarios, and pushing a commit with no support for IPFS users that can block our release pipeline until it is added back in. We still need to give notice to our users and inform them to spin up their own IPFS node instead of the embedded one
Instead of deleting the tests, the right approach is to migrate them to the new models as planned in https://github.com/bacalhau-project/bacalhau/issues/3832, and to local publisher instead of IPFS as planned in https://github.com/bacalhau-project/bacalhau/issues/3816. Now we can speed things and remove embedded ipfs from tests before 1.5 release, but we shouldn't do more intrusive things or fully remove embedded ipfs without communicating that early to users.
@wdbaruni agreed, which is why this remains in draft.
agreed, which is why this remains in draft.
You've asked me to review this proposal and I did :)
model
) we plan to remove very soon as we move to the new API andmodels
package. We can always add similar testing back in a follow on.