bacalhau-project / bacalhau

Compute over Data framework for public, transparent, and optionally verifiable computation
https://docs.bacalhau.org
Apache License 2.0
706 stars 89 forks source link

Issue with passing through Golang #4429

Open aronchick opened 2 months ago

aronchick commented 2 months ago
❯ bacalhau-1.4.0 version
...
failed to setup repo: failed to reconcile repo: failed to initialize repo: failed to initialize repo: failed to create user key: user key file already exists at path: /Users/daaronch/.bacalhau/user_id.pem

We should never EVER pass through raw golang errors by default.

aronchick commented 2 months ago

Could be 1.4.0 only - reproducing.

frrist commented 2 months ago

This specific error will occur when v1.4.0 bacalhau attempts to open a v1.5.0 bacalhau repo.

frrist commented 2 months ago

duplicate of https://github.com/bacalhau-project/bacalhau/issues/4428, moving discussion there.

aronchick commented 2 months ago

Not a duplicate. This bug is because we passed through a raw wrapped go error.

frrist commented 2 months ago

This is an issue with 1.4 attempting to open a 1.5 repo. I have outlined why this issue occurs here: https://github.com/bacalhau-project/bacalhau/issues/4428#issuecomment-2362320578

I am not sure there is a fix we can land in 1.5 that will address this - repos are not compatible with older versions of bacalhau and the behavior/issue described here pertains to v1.4