coderabbitai[bot]
commented
2 weeks ago Walkthrough
The changes in this pull request introduce enhancements to the JobInformation, JobExecutions, and JobTabs components within the web UI. The JobInformation component now conditionally renders publisher information based on the job's tasks. The JobExecutions component has been significantly updated to include a new DownloadButton for downloading job results, with additional props and utility functions for improved functionality. The JobTabs component has modified its rendering logic to ensure that JobExecutions is only displayed when the necessary job data is present.
Changes
| File Path | Change Summary |
|---|---|
| webui/components/jobs/details/JobInformation.tsx | Introduced conditional rendering for "Publisher" information based on the first task's Publisher.Type. |
| webui/components/jobs/details/JobExecutions.tsx | Added DownloadButton component; updated props to include tasks and state; modified rendering logic for results; introduced new utility functions. |
| webui/components/jobs/details/JobTabs.tsx | Updated rendering logic to conditionally display JobExecutions based on the presence of job.Tasks and job.State. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant JobTabs
participant JobExecutions
participant DownloadButton
User->>JobTabs: View Job Executions
JobTabs->>JobExecutions: Check job.Tasks and job.State
alt If tasks and state exist
JobTabs->>JobExecutions: Render JobExecutions
JobExecutions->>DownloadButton: Render DownloadButton
DownloadButton->>User: User clicks to download
DownloadButton->>JobExecutions: Handle download logic
else
JobTabs->>User: Display no job data
end🐰 In the meadow where jobs do play,
A button now helps save the day.
With tasks and states, we check them twice,
Downloading results is now so nice!
So hop along, and don’t delay,
New features bloom in a joyful way!
🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Changes
This change allows WebUI users to download job results for local and s3 publisher types.
Testing
Pushed long running jobs to EC2 fleet and verified that download button is only enabled if publisher is supported and job is not running. S3 and local jobs download successfully.
Summary by CodeRabbit
New Features
Bug Fixes