search

bacalhau-project / bacalhau

Compute over Data framework for public, transparent, and optionally verifiable computation
https://docs.bacalhau.org
Apache License 2.0
711 stars 89 forks source link

login docker hub access in buildkite #4707

Closed wdbaruni closed 1 week ago

wdbaruni commented 1 week ago

login when accessing docker hub in buildkite to avoid rate limiting of unauthenticated access by docker. Without this we are getting these errors sometimes in buildkite:


Warning: you are not logged into registry-1.docker.io, you may experience rate-limitting when pulling images
--
  | +all \| apply build +base: earthfile2llb for +base: Earthfile:2:0 apply FROM node:20.8.1: resolve image config for node:20.8.1: unexpected status from HEAD request to https://registry-1.docker.io/v2/library/node/manifests/20.8.1: 429 Too Many Requests
  | +all \| in      github.com/bacalhau-project/bacalhau/webui:HEAD+base
  |  
  | Help: The remote registry responded with a rate limit error. This is usually because you are not logged in.
  | You can login using the command:
  | docker login <server>

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request introduces updates to several scripts: build_tarball.sh, build_webui.sh, test.sh, and lint.sh. Each of these scripts now includes a section that sources a new Docker authentication script, docker-auth.sh, and calls the docker_auth function for handling Docker credentials. Additionally, a new script, docker-auth.sh, has been added, which implements the Docker authentication logic, including error handling and configuration file creation. The overall structure and logic of the existing scripts remain intact.

Changes

File Path Change Summary
buildkite/scripts/build_tarball.sh Added sourcing of docker-auth.sh and call to docker_auth function for Docker authentication.
buildkite/scripts/build_webui.sh Added sourcing of docker-auth.sh and call to docker_auth function for Docker authentication.
buildkite/scripts/lint.sh Added sourcing of docker-auth.sh and call to docker_auth function for Docker authentication.
buildkite/scripts/test.sh Added sourcing of docker-auth.sh and call to docker_auth function for Docker authentication.
buildkite/scripts/docker-auth.sh Introduced new script with docker_auth function for Docker authentication and error handling.

Poem

In scripts where secrets hide,
Docker's keys now sit with pride.
Buildkite whispers, "Here they are,"
For tarballs, web, and tests afar.
With credentials snug and tight,
Our builds will soar to new heights! 🐇✨

🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.