bacalhau-project / bacalhau

Compute over Data framework for public, transparent, and optionally verifiable computation
https://docs.bacalhau.org
Apache License 2.0
711 stars 89 forks source link

expose backoff.BackoffDuration method #4714

Closed wdbaruni closed 4 days ago

wdbaruni commented 4 days ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 4 days ago

Walkthrough

The changes introduce a new method, BackoffDuration, across several structs and interfaces within the backoff package. This method calculates the backoff duration based on the number of attempts. The existing Backoff method is refactored to utilize this new method, enhancing code modularity. Test coverage is improved with a new test case for validating the backoff duration. Additionally, mock implementations are updated to support the new method, ensuring that the mocking capabilities align with the interface changes.

Changes

File Path Change Summary
pkg/lib/backoff/exponential.go Added method BackoffDuration(attempts int) time.Duration to Exponential struct. Refactored Backoff to call BackoffDuration.
pkg/lib/backoff/exponential_test.go Added test method TestBackoffDuration to validate backoff duration for various attempts.
pkg/lib/backoff/mock_backoff.go Added method BackoffDuration(attempts int) time.Duration to MockBackoff. Updated MockBackoffMockRecorder for new method. Changed attempts type in Backoff method to interface{}.
pkg/lib/backoff/noop.go Added method BackoffDuration(attempts int) time.Duration to Noop struct, returning zero duration.
pkg/lib/backoff/types.go Added method BackoffDuration(attempts int) time.Duration to Backoff interface. Added import for time package.

Poem

In the land of code where rabbits play,
A new backoff method brightens the day.
With attempts counted, durations now clear,
Our logic is tidy, let’s give a cheer! 🐇✨
No more confusion, just hops in the flow,
Backoff and test, watch our features grow!


🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.