bacalhau-project / bacalhau

Compute over Data framework for public, transparent, and optionally verifiable computation
https://docs.bacalhau.org
Apache License 2.0
716 stars 89 forks source link

make --download the default #777

Closed lukemarsden closed 11 months ago

lukemarsden commented 2 years ago

then bacalhau docker run ubuntu echo hello will print hello!

lukemarsden commented 2 years ago

should still be possible to specify --download=false if you don't want to wait for and download the results

wjam commented 2 years ago

@lukemarsden Should this also apply to bacalhau create?

lukemarsden commented 2 years ago

No I don't think so, I think the expectation is that bacalhau create works more like kubectl create, which doesn't wait for anything, whereas bacalhau docker run works like docker run which does print stdout (well, stream stdout but close enough)

aronchick commented 2 years ago

In my opinion I wouldn’t do this. The point of our system is that the stuff is too big to run locally - and it’s hosted in IPFS. If we want small ways to view, huge fan of bacalhau cat or bacalhau ls

lukemarsden commented 2 years ago

Maybe we could make --wait also print the truncated stdout and err, then make that the default then.

No big data downloads by default, but we still get echo hello works

On Tue, 4 Oct 2022, 15:48 David Aronchick, @.***> wrote:

In my opinion I wouldn’t do this. The point of our system is that the stuff is too big to run locally - and it’s hosted in IPFS. If we want small ways to view, huge fan of bacalhau cat or bacalhau ls

— Reply to this email directly, view it on GitHub https://github.com/filecoin-project/bacalhau/issues/777#issuecomment-1267124535, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACATUVI6UJYZQJEQFA2GGDWBQ7ULANCNFSM6AAAAAAQ34IWLU . You are receiving this because you were mentioned.Message ID: @.***>

js-ts commented 2 years ago

I agree with @aronchick, this won't work when the datasets are very big Downloading something without the permission of users, is not a good idea

js-ts commented 2 years ago

I don't disagree with printing stdout, I think it should be done by using ipfs cat /stdout instead of downloading the outputs

wdbaruni commented 2 years ago

--wait currently prints the truncated stdout and err. Can we close this issue?