search

bacbos / bolt-menu-editor

a visual menu-editor extension for the awesome bolt cms
Other
21 stars 23 forks source link

Hotfix request cycle translation fixes #14

Closed GwendolenLynch closed 9 years ago

GwendolenLynch commented 9 years ago

This fixes handling of translations on Bolt 2.2.5+ (see Bolt #3948) as after that point we enabled caching of translations.

bacbos commented 9 years ago

Having some troubles setting up a fresh bolt to review this, tried with tags 2.2.6 - 2.2.9 with no success. Can't yet tell if there's something fishy with my current set-up or with an updated dependency that's b0rking bolt, any idea? :/

The error occurs after setting up the first user when trying to access /bolt image

GwendolenLynch commented 9 years ago

Ah that is a combination of xdebug and Symfony. In either your xdebug.ini or php.ini you can set something like xdebug.max_nesting_level = 500

bacbos commented 9 years ago

Ah yes, it's working now, you were right. I installed my mac from scratch last week and PHP is still mostly running on the default configs.

Your PR is merged in, thanks a lot mate!

GwendolenLynch commented 9 years ago

You're very welcome… This should also make it work smoothly on Bolt 2.3 as well.