search

bacbos / bolt-menu-editor

a visual menu-editor extension for the awesome bolt cms
Other
21 stars 23 forks source link

Poor performance on large data sets #25

Closed Serhii-the-Dev closed 8 years ago

Serhii-the-Dev commented 8 years ago

Hi! In cases if there are huge amounts of content per a few content types, Menu Editor loading time increasing dramatically(~30 seconds). I've found that this line of code looks like it loads all content of all content types...I don't know why menu editor should do this, but when I've removed this line the editor still works well and a loading time value become normal(~400ms).

bacbos commented 8 years ago

You're right, it should not be doing this. Looking over it quickly, I'd say this is a relict from when the menu-editor was not using ajax-searching through content-types, so it loaded everything in advance to populate the static select-field.

Do you mind sending in a PR? :)

Serhii-the-Dev commented 8 years ago

Done, awaits for approval

bacbos commented 8 years ago

Great, thanks a lot!