search

bacbos / bolt-menu-editor

a visual menu-editor extension for the awesome bolt cms
Other
21 stars 23 forks source link

Add default (english) values to translation strings to prevent 'unreadable' string #50

Closed navelpluisje closed 7 years ago

navelpluisje commented 7 years ago

By adding the english translation as a default value to the translations, the dot-seperated keys will not appear when a translation fails like in https://github.com/bacbos/bolt-menu-editor/issues/48.

SvanteRichter commented 7 years ago

I'm not against it per se, but isn't this just covering up the real issue?

navelpluisje commented 7 years ago

True, but for the time being it will help people see a proper and understandable text after installation. See it more as a service until it is solved in Bolt;-)

SvanteRichter commented 7 years ago

Righto, sounds good

navelpluisje commented 7 years ago

Shall we do this one before releasing a new version. Just to take some annoyance away about the translation?

SvanteRichter commented 7 years ago

Sounds good

SvanteRichter commented 7 years ago

Fixed in #51 and added to the latest tagged release.