bacbos / bolt-menu-editor

a visual menu-editor extension for the awesome bolt cms
Other
21 stars 23 forks source link

[RFC] Add feedback after adding an item #74

Closed ankedsgn closed 6 years ago

ankedsgn commented 6 years ago

This happens especially when you have larger menus that are larger then your viewport.

How to reproduce

Result: link/path field is cleared and nothing seems to happen What does happen: On selecting the page, the new item is placed on the bottom of the menu. This might be out of your viewport. Hence the feeling that 'nothing happens and it's broken'

Possible solutions

Option 1:

Option 2:

Background

I First wanted to file a bug for 'it's broken, nothing happens when I add a new item' and then I discovered 10 new items with the same label somewhere on the bottom of my menu..

SvanteRichter commented 6 years ago

Option 2 sounds good to me, do you want to PR that? it's probably just something like adding a line with showFlash('Menuitem added!') here: https://github.com/bacbos/bolt-menu-editor/blob/master/web/menueditor.js#L222

ankedsgn commented 6 years ago

Yes, I was thinking of digging into it and doing exactly that. Thnx for pointing out where!