search

baccon404 / procurement

Automatically exported from code.google.com/p/procurement
0 stars 0 forks source link

Enhancement: Refresh Recipes #241

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The contents of a league's stash can be refreshed, but the list of recipes does 
not get updated to reflect any changes.  This patch adds a context menu to the 
list of recipes with an option to refresh the recipes.

Original issue reported on code.google.com by cmaca...@gmail.com on 26 Apr 2014 at 9:01

GoogleCodeExporter commented 8 years ago 
Interesting, the league change event should be firing, which will call the 
refresh method. I'll look into this.

Thanks for all the patch submissions!

Original comment by stickymaddness on 10 May 2014 at 11:23

GoogleCodeExporter commented 8 years ago 
You're welcome!

As far as I know, everything is working properly in regards to the recipes 
being recalculated when changing leagues.  However, I wanted a way to refresh 
the recipes without needing to change the league.  My workflow is generally 
this: have Procurement open and up to date; play some PoE and update the stash; 
refresh relevant tabs in Procurement; switch to recipe tab and right click and 
refresh the recipes.  Having to switch the league works, but was too much work 
for my tastes.

Original comment by cmaca...@gmail.com on 11 May 2014 at 2:33

GoogleCodeExporter commented 8 years ago 
Sorry I was completely off in the wrong direction, in my defense it was 2am :p

Having looked at it again it makes perfect sense, and I'll look at implementing 
this.

Original comment by stickymaddness on 11 May 2014 at 12:04

GoogleCodeExporter commented 8 years ago 
No problem.  My initial description wasn't really that clear.

I noticed that you started updating the Github page with the latest code.  If 
you'd prefer, I can rework my outstanding patches into merge requests there.  
If you're moving to Git, that probably would work out better for both of us.

Original comment by cmaca...@gmail.com on 12 May 2014 at 12:25

GoogleCodeExporter commented 8 years ago 
Yeah, I've pretty much moved over to git myself, but I will still be keeping 
the google code svn repo in sync, so you're welcome to send through stuff on 
github or here via svn patches.

Original comment by stickymaddness on 13 May 2014 at 3:55

GoogleCodeExporter commented 8 years ago 
I ended up handling this slightly differently, when a tab is refreshed it will 
also invalidate the Recipe view, so that when you navigate back to the Recipe 
view it will have automatically updated, without the need to click refresh 
again.

Original comment by stickymaddness on 14 May 2014 at 3:39