baccon404 / procurement

Automatically exported from code.google.com/p/procurement
0 stars 0 forks source link

Enhancement: Move GearBaseType definitions into Data.xml #244

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
As we've discussed earlier (in issue 83), the preferred way of storing the base 
types for each type of gear would be in an xml file.  This patch moves those 
definitions into a Data.xml file (which in theory could hold other types of 
data in the future).  I used the Settings class to load and read in these 
values, but, if you want, this can be changed to use an analogous Data class 
(so each class is only reading in one file each).

Original issue reported on code.google.com by cmaca...@gmail.com on 27 Apr 2014 at 5:07

GoogleCodeExporter commented 8 years ago
The patch in the initial description has a bug in it that I didn't catch.  
Attaching here a fixed version.

Original comment by cmaca...@gmail.com on 27 Apr 2014 at 9:32

Attachments:

GoogleCodeExporter commented 8 years ago
You've been busy, I'll look into this change asap!

Original comment by stickymaddness on 10 May 2014 at 11:36

GoogleCodeExporter commented 8 years ago
Rejoice! GearTypeRunner is clean again! :)

Original comment by stickymaddness on 15 May 2014 at 5:20