search

bachlab / PsPM

A matlab suite for Psycho-Physiological Modelling
GNU General Public License v3.0
43 stars 10 forks source link

GUI import eyelink/viewpoint/smi do not allow to chose marker channel #145

Closed irojkov-ph closed 4 years ago

irojkov-ph commented 4 years ago

Summary

Using GUI for importing data of the format eyelink/viewpoint/smi do not allow users to specify the marker channel number and uses only the default one. I guess this is not very convenient for users which utilize the batch editor of PsPM and have multiple marker channels in their data.

Steps to Reproduce

  1. Open the Batch editor in the "Import" mode.
  2. Select one of the following data types: eyelink/viewpoint/smi
  3. Create a "Data Column" of type "Marker"
  4. Then under "Data Column Number" there is only one option: "Default Data Column Number" ; even thouh the description says that one could technically chose to specify a number.

Expected Results

We should be able to specify a number for the marker channel column number

Actual Results

Currently we do not have this option

(Optional) Possible Cause and Solutions

I guess it is related to the lines 341-356 in the pspm_cfg_import function.

Technical Info

irojkov-ph commented 4 years ago

@sammaxwellxyz I assigned it to both of us but I think I'll fix it myself on Monday. It could be nice to fix it for the release.

irojkov-ph commented 4 years ago

At the end its not a bug but the normal behavior ! It depends on the settings.import.datatypes(datatype_i).automarker option (see pspm_init under "general import settings" for more information). I close the issue.