search

bachlab / PsPM

A matlab suite for Psycho-Physiological Modelling
GNU General Public License v3.0
43 stars 10 forks source link

Trim for processing missing epochs #268

Closed teddychao closed 3 years ago

teddychao commented 3 years ago

Summary

Trim assumes that the data to be processed contains sufficient information, shown as dominating non zero values. Values of start and end points for trimming are generated through combining both the original data and the reference. This logic makes it not applicable for processing missing epochs, because missing epochs contains only 0 and 1. Therefore, trim needs to be updated for being applicable for missing epochs.

teddychao commented 3 years ago

@dominikbach I have an idea in my mind. I will pull a request for this issue. May I ask you to have a look there. Many thanks.

dominikbach commented 3 years ago

@teddychao since I wrote the update to split_sessions, I'll have a quick go at it, I think it can be simplified.

dominikbach commented 3 years ago

@teddychao

pspm_split_sessions combines the marker data with the missing data channel and then calls pspm_trim. There is no issue there, unless you disable the marker channel. So I think this issue can be closed.