Closed teddychao closed 3 months ago
Hi @fedmanci and @SerenXia I have put your comments on our last meeting to this issue. I hope this is exactly what you suggest. Please feel free to comment if there is any information missing. It would be grateful if you can let us know your thoughts about this issue @dominikbach . Thanks.
Recent development of PsPM aims at generalising the variable
options
in all pspm functions.channel_action
, one of the subfields ofoptions
, has been generalised for every function except forpspm_write_channel
. For every other function,channel_action
is a subfield inoptions
, and it can be whether mandatory or optional. Forpspm_write_channel
,channel_action
is an individual variable which is parallel tooptions
. This is an exception forchannel_action
and we may want to reconsider where to put it.We have discussed about this issue in this week's group meeting. Our colleagues have provided their suggestions:
channel_action
should be prioritised inpspm_write_channel
because it plays a vital role in the process ofpspm_write_channel
. As an individual variable, it will cause attention of users and force them to always provide value for it.channel_action
could be renamed inpspm_write_channel
. This is because throughout PsPM,options
always tends to have the fieldchannel_action
when applicable. Users may become confused whether to specify such value in the individual variable ofpspm_write_channel
or the field ofoptions
inpspm_write_channel
.