search

bachlab / PsPM

A matlab suite for Psycho-Physiological Modelling
GNU General Public License v3.0
43 stars 10 forks source link

Check channel replacing behaviour #533

Closed teddychao closed 9 months ago

teddychao commented 1 year ago

Summary

Users have reported that PsPM does not replace channel when users have set channel_actions as replace over add. Relevant functions may include (but may not only limit to) pspm_convert_pixel2unit, pspm_convert_gaze_distance and pspm_pupil_pp. It is necessary to check the reason and avoid this issue for any other functions which have this feature.

dominikbach commented 1 year ago

User reported that channel is added when the units are changed and no channel with new units exist. This should be the desired behaviour. Could you confirm @teddychao?

teddychao commented 1 year ago

User reported that channel is added when the units are changed and no channel with new units exist. This should be the desired behaviour. Could you confirm @teddychao?

Hi @dominikbach Apologies. This is the question proposed by Marina. I saw on Slack it seems to be a misunderstanding for her and the current behaviour is expected. Shall I close this issue, if my understanding is correct now?