teddychao
commented
10 months ago I have fixed the issue of overwriting. I am unsure if it is good practice to comment the test functions.. Let me check if they can be fixed shortly in this pull request.
Update details
| Function | By | Update detail |
|---|---|---|
check_model |
Dominik | / |
con1 |
Dominik | / |
init |
Teddy | Change the default mode to ~development. |
load_data |
Teddy | The issue of checking overwriting should be fixed in pspm_overwrite. |
overwrite |
Teddy | A Fix a bug of data transferring at line 64 (66 in newer version). B Add a warning when (a) the file does exist (b) overwriting is set to be false. |
pupil_correct_eyelink |
Dominik | / |
pupil_pp |
Teddy | My understanding is the preprocessed data, as the outcome of pupil_pp, should not contain the keyword pp. |
find_valid_fixations_test |
Teddy | overwrite needs to be set to be true for test functions. |
interpolate_test |
Teddy | overwrite needs to be set to be true for test functions. |
load1_test |
Teddy | overwrite needs to be set to be true for test functions. |
pp_test |
Teddy | overwrite needs to be set to be true for test functions. |
process_illuminance_test |
Teddy | overwrite needs to be set to be true for test functions. |
pupil_correct_eyelink_test |
Teddy | A overwrite needs to be set to be true for test functions. B The test function has now allowed the warning caused by multiple selected channels at line 62 [1]. |
pupil_pp_test |
Teddy | overwrite needs to be set to be true for test functions. |
[1] The new version of pupil_pp will not add text pp in the output data, therefore multiple channels will be selected if the keyword for channel selection is pupil. The warning caused by line 62 at pupil_correct_eyelink_test reflects this update. I have now updated the test function for allowing this warning.
Fixes #578 .
Changes proposed in this pull request: