bachphuc / webp

Automatically exported from code.google.com/p/webp
0 stars 0 forks source link

SIMD optimizations not always included when compiling via Android.mk #117

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Attached patch resolves the following issues
- Android.mk should include dec/enc/upsampling sse2 variants. This provides 
sse2 optimizations when compiling for Android/x86
- LOCAL_ARM_NEON should be set to true when compiling for armeabi-v7a. 
Otherwise __ARM_NEON__ is not defined and all neon code is removed by the 
preprocessor.

Original issue reported on code.google.com by pepijn.v...@gmail.com on 20 Apr 2012 at 9:59

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks this looks ok.
There may be some further work that could be done:
- the libs could be split as in the android tree
- I'm not sure compiling in thumb mode for arm is the best choice, but I 
haven't done any profiling to verify.

Original comment by jz...@google.com on 20 Apr 2012 at 6:39

GoogleCodeExporter commented 9 years ago
https://gerrit.chromium.org/gerrit/#change,20732

Original comment by jz...@google.com on 20 Apr 2012 at 7:25

GoogleCodeExporter commented 9 years ago
Merged.

Original comment by jz...@google.com on 20 Apr 2012 at 7:51