bachrathyd / MDBM.jl

Multi-Dimensional Bisection Method: Julia package to determine the set of roots for 'any' parameter dimension and 'any' codimension
MIT License
33 stars 5 forks source link

Small chance of duplicated check in the 'checkneighbour' function #8

Open bachrathyd opened 5 years ago

bachrathyd commented 5 years ago

In the "checkneighbour" function, first all the neighbours of the n-cubes are generated, and the non-bracketing are filtered out. Then the neighbours of the "new bracketing n-cubes" are analysed in a while loop. However, it is possible, that the neighbour of a "new bracketing n-cubes" were checked before (as a neighbour of the original n-cube). This will not lead to extra function evaluation due to the memoization, however the interpolation will be carried out multiple times.