[Android Bootcamp] Assigment 1 - Instagram Viewer

[bachvand5]

Hi, this is my submission for the 1st homework. Sorry for the late. I was pulled out of my desk before I finished the readme and the issue.

@coderschool

[chug2k]

@coderschoolreview

[hoanle]

@bachvand5

Week 1: Instagram Viewer

:+1: thank you for your submission. The goal of this homework was to teach you RelativeLayout, ListView, networking with APIs, and loading remote images. These concepts are the foundation of nearly every app.

The app looks nice but a bit simple

A few notes after checking out the code:

• Fix integers & texts are used in the xml file, they should be put in dimens.xml file or strings.xml file
• Variables of a class should be private and accessed by getter and setter (OOP)
• Good to see you playing around with different layout types, especially RelativeLayout, one of the most popular and powerful one. I also saw a lvComments listview inside item_photo.xml. As i said, it's not a good practice to put a listview inside a listview. And i really the username textview, it's nice and catching-the-eye
• Consider overriding onFailure method to handle network failures appropriately.
• Consider using the ViewHolder pattern to improve performance of photos ListView.And reduce the logic code inside getView
• Nice to see you used the SwipeRefreshLayout
• Consider using the ButterKnife library annotations for declaring handles to view objects.
• You can use Gson to parse JSon, save time and effort

You can read a detailed Project 1 Feedback Guide here which covers the most common points we see for this project, if you'd like to evaluate yourself further.