[Android Bootcamp] Prework - Review ToDoList App

[bachvand5]

Hi, I completed the basic version of ToDoList app. Please review. Thank you.

/cc @coderschoolreview

[coderschoolreview]

Thank you for your Android submission, bachvand5!

:star: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

[bachvand5]

Hello, I updated the app to new version with additional features. Please check it out. Thanks.

/cc @coderschoolreview

[hoanle]

@bachvand5

Thanks for the submission

In general:

• The app runs smoothly without any big issue (crashes)
• Nice CustomListViewAdapter & using the ViewHolder to hold view (ListView performance increase)
• Nice ListviewRow class, good practice

Detail & Suggestions:

• Item Title should be check before adding to the list. Currently can add empty item by clicking on ADD ITEM button
• "New Due" is suppose to be date but it could be anything now (even empty). You could check the format of input String to make sure it's Date string.
• The state of CheckBox is only saved at the EditItemActivity. At the MainActivity Checkbox can be checked but the state is not saved
• If a view is used several times, you should hold a reference to that view. Do not need to grasp the view each time (function onAddItem: etNewTask, etNewDue...)
• You can use Serializable for model object and freely transfer it through activity, fragment

[bachvand5]

@coderschoolreview Thanks for your review. I updated the app to use DialogFragment for adding new item and put blank restriction to EditText NewTask and NewDue. I still get problem to listen to the Checkbox click to save to file :(