search

back2dos / travix

Travis helper.
The Unlicense
33 stars 12 forks source link

Don't change working directory to "bin/java" when running java builds. #127

Closed sebthom closed 3 years ago

sebthom commented 3 years ago

This was introduced for an unknown reason with https://github.com/back2dos/travix/commit/69c2b8ffe9cef9282d4cca671e14c1331140d474 and results in different build behavior on Java compared to all other platforms.

I moved the changing of the CWD inside the "buck" related if branch, however I would prefer to have the buck config stuff removed again completely since it is not documented and only implemented for the java platform - thus worshiping the maximum surprise principal.

By undoing the CWD change I could also revert my changes from https://github.com/back2dos/travix/commit/9ebeb8ec81798d5e9346826c0a10217ddf5164cf.