backbone-paginator / backbone.paginator

A pageable, drop-in replacement for Backbone.Collection called Backbone.PageableCollection.
http://backbone-paginator.github.io/backbone.paginator/
MIT License
1.41k stars 253 forks source link

2.0.6 introduced bug with _.includes in some environments #384

Closed evanrmurphy closed 6 years ago

evanrmurphy commented 7 years ago

It appears a reference to _.contains was changed to _.includes between backbone.paginator 2.0.5 and 2.0.6. This caused a bug in our web app, although I don't understand why because I'm pretty sure it's referencing an import of Underscore 1.8.3 which supports _.includes as an alias for _.contains.

We are reverting to 2.0.5 to fix the problem. I realize this may not be very helpful without more detail which I don't have time to provide, but I thought at least the knowledge of this problem for some might be useful.

wyuenho commented 6 years ago

Should be fixed by #389