search

backdrop-contrib / backdrop-drush-extension

A set of commands and boot class for Drush and Backdrop CMS.
GNU General Public License v2.0
14 stars 18 forks source link

[bmake] Support non-Backdrop projects #134

Open ghost opened 6 years ago

ghost commented 6 years ago

As per https://github.com/backdrop-contrib/drush/issues/130#issuecomment-359305446, I'd like to see bmake support non_backdrop projects, such as other GitHub repositories, custom URLs, jQuery libraries, etc.

An example use-case for this would be my personal Backdrop base theme: https://github.com/PackWeb/pw_theme It's not on backdrop-contrib as it's specific to my needs, but I use it on every Backdrop site I build. So the ability to build a Backdrop site from a make file that included this would be great.

Other use cases might be downloading jQuery libraries, etc.

ghost commented 6 years ago

Also, when you do this, please allow for both keeping and removing .git directories.

On the one hand, if you download a git repo, you often don't want all the hidden files and everything that comes with it (just download and forget). On the other hand, sometimes you want to keep the git repo linked upstream so you can pull down changes in future.

Drupal's drush has a --working-copy argument for keeping .git directories (it deletes them otherwise).

ghost commented 5 years ago

I've started a PR (https://github.com/backdrop-contrib/drush/pull/187) for this that allows cloning a git repository (e.g. pw_module[git] = git@github.com:PackWeb/pw_module.git), but I'm struggling to get the path working properly. Currently it's cloning the repo into /BACKDROP_ROOT/modules/... (i.e. its not converting BACKDROP_ROOT into the actual root path). Help needed please!

ghost commented 5 years ago

There are other possibilities to implement after this (e.g. patches, third-party libraries, etc.), but this suits my needs for now, so unless others require additional functionality, I'd say let's try and get this working, release, and then add more functionality as requested.

serundeputy commented 5 years ago

Merged! thanks @BWPanda this will ship w/ 1.x-1.1.0

ghost commented 5 years ago

@serundeputy Thanks for this, but were you able to fix the bug with the path: https://github.com/backdrop-contrib/drush/issues/134#issuecomment-512240767 The PR wasn't ready to be committed yet, at least until that was fixed...

serundeputy commented 5 years ago

Sorry about that @BWPanda ; no i did not fix the path issue.

I tried to look at it today, but I can't remember how to test bmake in lando :confounded:

I should have written down the devOps for bmake development :cry:

If you have the steps it takes we should dump them into a /commands/make/README.md file in case i forget again (very probable).

ghost commented 5 years ago

@serundeputy Try this: https://github.com/BWPanda/drush-bmake-testing

If you want to keep it around for future, I'm happy to transfer it over to you, or you can merge it into the Drush repo if appropriate.

serundeputy commented 5 years ago

thanks; that is essentially the same as what i have: https://github.com/backdrop-contrib/drush/wiki/Contributing-code-to-the-Backdrop-drush-extension. which is working fine, but not for bmake

I thought there was some additional hoop i had to jump through, but i'm drawing a blank, but if it is working for you then maybe i just need to destroy and start anew;

when i come by some time; i'll do that

ghost commented 5 years ago

@serundeputy I remember trying to start with your dev lando file, but having issues... After playing around and changing things, I ended up with the one I linked to (e.g. the main difference being I still use the packaged version of Drupal Drush, but then the git repo version of Backdrop Drush).

Destroy all the things! 😊