Port views drush commands

backdrop-contrib / backdrop-drush-extension

A set of commands and boot class for Drush and Backdrop CMS.

GNU General Public License v2.0

13 stars 18 forks source link

Port views drush commands #190

Open klonos opened 5 years ago

klonos commented 5 years ago

As mentioned in https://github.com/backdrop/backdrop-issues/issues/3729

As part of the tasks in #3719, we need to account for this issue in Views 7.x, and this respective commit.

It seems that we have removed the /drush directory from our version of views, so where should that code live now? Do we support this in https://github.com/backdrop-contrib/drush ??

...to which @quicksketch replied:

Yes, any core-specific commands should be moved into the backdrop-contrib drush project. Note at the time we ported Views into Backdrop, there was no backdrop-contrib/drush. So all commands are probably missing an may need to be ported.

PR by @klonos https://github.com/backdrop-contrib/drush/pull/191

klonos commented 5 years ago

...should things live under /commands/core/views.drush.inc @serundeputy?

klonos commented 5 years ago

Starting a PR: https://github.com/backdrop-contrib/drush/pull/191

Untested; simply added the current version of the views.druch.inc file from https://git.drupalcode.org/project/views/blob/7.x-3.x/drush/views.drush.inc, with the following changes:

changed instances of variable_get()/variable_set() with state_get()/state_set()

serundeputy commented 5 years ago

I'd probably put it in a new /commands/views directory (possibly breakout commands into there own files, but I'd have to look at the scope of the commands).

Having said that looks like there is much work to be done and testing in the command implementations.

I'm not sure that variable_*et --> state_*et is the right way to go ... usually things that were variables in Drupal are config in Backdrop, but I'd have to do a deep dive into the code here.

In general it is good to have this issue to get the ball rolling on these views commands.