backdrop-contrib / backdrop-drush-extension

A set of commands and boot class for Drush and Backdrop CMS.
GNU General Public License v2.0
13 stars 18 forks source link

Issue #231: Fix 'version' command bug #232

Closed ghost closed 3 years ago

ghost commented 3 years ago

Fixes https://github.com/backdrop-contrib/backdrop-drush-extension/issues/231

serundeputy commented 3 years ago

thanks @BWPanda

this did not work for me:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   632  100   632    0     0   3001      0 --:--:-- --:--:-- --:--:--  3009
100 4879k  100 4879k    0     0  4771k      0  0:00:01  0:00:01 --:--:-- 6757k
Command backdrop-drush-version needs a higher bootstrap level to run - you will need to invoke drush from a more functional Drupal environment to run this command.                                                                                  [error]
The drush command 'version' could not be executed.                                                                                                                                                                                                   [error]
ERROR ==> The drush command 'version' could not be executed.                                                                                                                                                                                                   [error] 
ghost commented 3 years ago

@serundeputy I wasn't sure how to test this with Lando... But it does fix the more general problem described in the linked issue.

klonos commented 3 years ago

Hey @BWPanda and @serundeputy 👋 ...I guess https://github.com/backdrop-contrib/backdrop-drush-extension/pull/233 is an attempt to fix the test failures. Right? ...otherwise, it seems to be @BWPanda's PR + a commit to revert composer to 1.x in .travis.yml.

ghost commented 3 years ago

@klonos Seems that way...

ghost commented 3 years ago

I changed the bootstrap for the 'version' command from DRUSH_BOOTSTRAP_DRUSH (which is only used in one other place - grn.drush.inc) to DRUSH_BOOTSTRAP_NONE (which is used in 5 other places. Hopefully this makes it easier to understand what this line means.