search

backdrop-contrib / backdrop-drush-extension

A set of commands and boot class for Drush and Backdrop CMS.
GNU General Public License v2.0
13 stars 18 forks source link

Add description key name to prevent e-notice #244

Closed eileenmcnaughton closed 3 years ago

eileenmcnaughton commented 3 years ago

I'm seeing enotices on drush 8.3.2 as it is looking for these to be keyed by 'description'

I believe this is fully backwards compatible to earlier drush versions

serundeputy commented 3 years ago

thanks @eileenmcnaughton !

This looks good to me, tests have stopped running since we need to migrate to travis-ci.com instead of org. I've put in a request for permission to migrate from a Backdrop-contrib org owner.

I'd like to see the tests run successfully, but if we don't hear from an owner in a few days we can probably just merge.

eileenmcnaughton commented 3 years ago

Cool!

serundeputy commented 3 years ago

@quicksketch did you receive an email request to allow travis-ci.com access to the backdrop-contrib/backdrop-drush-extension repo?

If so can you approve?

thanks, ~Geoff

quicksketch commented 3 years ago

Hi @serundeputy! I did! Sorry I meant to approve it but it was buried. I have granted the Travis-CI app on all of backdrop-contrib.

eileenmcnaughton commented 3 years ago

It still doesn't look like travis has run

serundeputy commented 3 years ago

you are correct. It needs to be migrated which means, we need to opt it into the beta migration program which I think @quicksketch has to do.

If you can just verify for me that you've manually tested; I'll merge it in.

thanks.

eileenmcnaughton commented 3 years ago

Yes - I manually tested it

serundeputy commented 3 years ago

thanks! merged.