If no stable release found consider Github?

backdrop-contrib / backdrop_upgrade_status

Checks to see if the installed modules on a Drupal 7 site are ready for upgrade to Backdrop CMS.

1 stars 5 forks source link

If no stable release found consider Github? #8

Closed indigoxela closed 2 years ago

indigoxela commented 4 years ago

That's a useful tool!

A screenshot: screenshot-output

Which leads me to a question/idea...

If there's no stable release yet it might be useful to check for an ongoing port on Github. Both, i18n and l10n_update have no stable release, but both projects already exist in backdrop-contrib. If people only rely on the report they get, they might miss that someone's already working or at least has started working on a port. And that they could contribute to it.

Or does this exceed the purpose of this module?

herbdool commented 3 years ago

I think it's fair to include. Feel like creating a PR?

herbdool commented 3 years ago

I think it's first checking updates.backdrop.org for release and project info. In this case we might need a fallback which would check github to see if a page exists with the same project name. Or put in a hardcoded array to check.

jenlampton commented 3 years ago

Interesting, on my local I'm seeing the github projects (without releases), in yellow, as "dev versions" and the ones on b.org (with releases) in green, as "official releases". I wonder if there's an issue with connecting to github from some locations, that makes the dev versions not work consistently?

jenlampton commented 3 years ago

I've confirmed that this feature already exists:

@indigoxela can you update to the latest version and see if you are still having the problem?

indigoxela commented 3 years ago

@jenlampton in the meantime i18n does have a release (alpha), that's why it appears as available in the list. Modules without release still don't show up. Leaflet and Geophp do exist on Github, but have no release yet. Tested with version 7.x-1.1.

upgrade-status-dev

That's no bug, it's a feature request.

jenlampton commented 3 years ago

in the meantime i18n does have a release (alpha)

Ah, right! nice :)

Modules without release still don't show up

Okay, I'm seeing this now too. Sorry for the hasty assumption :)

jenlampton commented 3 years ago

Alright, I've committed a first-go of this to the repo. I discovered the GitHub API is rate-limited for anonymous requests, so I've switched to checking the url for a 404 to see if the project exists in backdrop-contrib for the time being. I left all the github api code in there (commented out) so that it should be able to set up as soon as we figure out how to properly use the API :)

I'll leave this issue open until we can add that, but at least people can see projects that are in development now.

jenlampton commented 2 years ago

Closing this issue in favor of https://github.com/backdrop-contrib/backdrop_upgrade_status/issues/32