search

backdrop-contrib / backup_migrate

Port of the Drupal backup_migrate module to Backdrop
GNU General Public License v2.0
7 stars 14 forks source link

Issue #125. Remove non-sensible directory defaults for config active and staging. #142

Closed argiepiano closed 9 months ago

argiepiano commented 9 months ago

Fixes #125

indigoxela commented 9 months ago

Hm... if I run tests locally, they fail, too. Not exactly the same failures. On php 8.2 - which might be a little too new. Currently test in GHA run on 7.4.

argiepiano commented 9 months ago

Thanks @indigoxela. I'll check tests in 8.2.

BTW these tests on GHA have been failing randomly - when I run them again they pass usually. The error this one shows is completely puzziling: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'backdrop.simpletest331674cache_entity_comment' doesn't exist: SHOW CREATE TABLEsimpletest331674cache_entity_comment;

argiepiano commented 9 months ago

I just ran all 3 backup_migrate tests locally on 8.2 based on the dev version and with this patch, and they are all passing for me. Perhaps you are using an older dev version? If you have the time to run those again locally at some point and find issues again, pls let me know.

I'm going to close and reopen this to run the GHA tests again.

argiepiano commented 9 months ago

Tests pass on reopening 🙄

indigoxela commented 9 months ago

Tests pass on reopening

That's good. And bad. But currently good.