backdrop-contrib / backup_migrate

Port of the Drupal backup_migrate module to Backdrop
GNU General Public License v2.0
7 stars 14 forks source link

Email notification goes to wrong address (from-only email address) #159

Open jenlampton opened 7 months ago

jenlampton commented 7 months ago

The email is sent to the address configured for your site at admin/config/system/site-information.

As specified in the description text on that field, this address is the FROM address for your backdrop site, and as-such, it's default value is set to no-reply@ to indicate that messages should never be sent here.

People got very confused by this in Drupal and often sent messages to this address, so I expect this issue pre-dates the backdrop version of the module :)

Instead, I would recommend that we use the address defined for update module at /admin/reports/updates/settings. If that module is not enabled, or if the email address has no value, we could make the field required on the backup and migrate settings page, and perhaps also set a warning on the status report via hook_requirements() when there is no value provided.

This is a follow-up to https://github.com/backdrop-contrib/backup_migrate/issues/151.