Remove the use of backup_migrate_include() entirely

backdrop-contrib / backup_migrate

Port of the Drupal backup_migrate module to Backdrop

GNU General Public License v2.0

7 stars 14 forks source link

Remove the use of backup_migrate_include() entirely #161

Closed argiepiano closed 4 months ago

argiepiano commented 8 months ago

backup_migrate_include() seems to cause some issues in some instances when it appears in update hooks (see #160).

In Drupal 7, this function was completely removed. We should do the same. See https://www.drupal.org/project/backup_migrate/issues/3154166

izmeez commented 5 months ago

The drupal issue opening explanation may help in understanding this fix:

With modern PHP there's no need to track which files are loaded, just use include_once() when needed and the rest will be taken care of.

argiepiano commented 4 months ago

@cellear I would like to merge this PR that has been sitting here for 3 months. I've tested without any issues. Let me know if you can test, and I'll wait a bit for you to do so.

cellear commented 4 months ago

Let me see if I can find the time this weekend to make an attempt at that.

argiepiano commented 4 months ago

Thanks! Testing should be simple. There is actually no bug, rather a "task" that was ported from D7. So the idea is to install BAM and patch it on a site, then try to create as many types of backups as possible.